refactor: rename chain_dag to chain_let for semantic clarity#713
Closed
lmeyerov wants to merge 3 commits into
Closed
refactor: rename chain_dag to chain_let for semantic clarity#713lmeyerov wants to merge 3 commits into
lmeyerov wants to merge 3 commits into
Conversation
lmeyerov
force-pushed
the
feature/gfql-pr4-consolidate-wire-protocol
branch
from
July 26, 2025 04:57
63cf6a0 to
75efcf7
Compare
lmeyerov
force-pushed
the
feature/gfql-pr5-rename-chain-dag-to-let-v2
branch
from
July 26, 2025 05:36
7924fc9 to
9c36701
Compare
This was referenced Jul 26, 2025
lmeyerov
force-pushed
the
feature/gfql-pr5-rename-chain-dag-to-let-v2
branch
from
July 26, 2025 09:02
9c36701 to
b99dbda
Compare
- Rename chain_dag.py → chain_let.py - Update chain_dag_impl → chain_let_impl - Rename test files and update all references - Update comments and documentation - Maintain backward compatibility in wire protocol This change improves semantic clarity as 'let' better represents the binding functionality than 'dag' (directed acyclic graph).
Fix mypy type error where from_json returns Union type but ASTLet expects Dict[str, ASTObject]. Added explicit cast to satisfy type checker. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…f to ASTRef - Fixed merge conflicts in chain_let.py and test_chain_let.py - Updated test_call_operations.py to import ASTRef instead of ASTChainRef - Resolved all remaining refactoring conflicts from chain_dag → chain_let rename 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
lmeyerov
force-pushed
the
feature/gfql-pr5-rename-chain-dag-to-let-v2
branch
from
July 26, 2025 09:49
b99dbda to
db54cb6
Compare
Closed
8 tasks
Contributor
Author
|
Superseded by PR #715 which consolidates all GFQL code changes into a single PR for easier review and testing. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames chain_dag to chain_let throughout the codebase for semantic consistency with Let bindings.
Stack Position: #4 - Builds on the full GFQL implementation and provides semantic consistency.
Stack Order
The complete GFQL stack (merge in this order):
Semantic Rename: chain_dag → chain_let
Rationale
The original name "chain_dag" was misleading because:
Files Renamed
graphistry/compute/chain_dag.py→graphistry/compute/chain_let.pygraphistry/compute/gfql/chain_dag.py→graphistry/compute/gfql/chain_let.pyFunction Renames
chain_dag()→chain_let()- Public API functionchain_dag_impl()→chain_let_impl()- Internal implementationImport Updates
chain_dagtochain_letTest File Updates
test_chain_dag.py→test_chain_let.pytest_chain_dag_gpu.py→test_chain_let_gpu.pytest_chain_dag_remote_integration.py→test_chain_let_remote_integration.pyAPI Compatibility
chain_dag()functionDocumentation Updates
Benefits
This rename completes the semantic alignment of the GFQL implementation, making the codebase more intuitive and maintainable.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com