Allow queryEngine to operate async#499
Merged
Merged
Conversation
kevinmarr
approved these changes
Jul 13, 2026
This previously assumed that all queries would come in on the same tick, but that might not be true in a lot of cases (notably iframes, but also page js could cause this). Instead, run queries as they come in. Also fixed an issue where page navigation would continue to run old queries. I still want to support slightly out-of-order pages, where the code-fenced query might be below the component that uses it. To do that, I moved the registration of those queries to component initialization, while queries still happen on mount.
still flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This previously assumed that all queries would come in on the same tick, but that might not be true in a lot of cases (notably iframes, but also page js could cause this).
Instead, run queries as they come in. Also fixed an issue where page navigation would continue to run old queries.