Allow js/css#498
Merged
Merged
Conversation
We want to move to a world where pages can do basically anything. #468 added sanitization that we don't really want, so effectively revert it.
I want something lightweight and not svelte depedant. This will also make it easy for us to sandbox pages
Contributor
|
Prob need an update to base.md |
Contributor
Author
Yeah, but I'm not sure if it should be in this PR? I kinda want to play with it more to get a sense of where it works and doesn't before agents start using it more widely. For example, this allows svelte conditionals and it'd be neat to show and hide bits of the ui depending on if a query returns rows, but at the moment there's no api to use for that. It's not even clear how much we want to encourage that, as it ties graphene md to a particular version of svelte. |
Contributor
|
Ah ok. Fine by me |
kevinmarr
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the sanitization we had, as we want to allow js/css on pages.
Locally this should be fine. On graphene cloud, we'll sandbox pages in an iframe, and I simplified the api for binding url params to inputs in order to support that.