Skip to content

feat(ts): convert config + util to TypeScript (Phase 3) - #59

Merged
graphanov merged 1 commit into
mainfrom
forge/issue-51-config-util-typescript
Jun 29, 2026
Merged

feat(ts): convert config + util to TypeScript (Phase 3)#59
graphanov merged 1 commit into
mainfrom
forge/issue-51-config-util-typescript

Conversation

@graphanov

Copy link
Copy Markdown
Owner

Summary

  • Converts the Phase 3 config/util boundary from JavaScript to TypeScript.

Scope

  • src/config.js and src/util.js are renamed to .ts with explicit types; PersistedUserConfig is shared from src/types/index.ts; affected tests import compiled dist modules after build.

Out of scope

  • No merge, publish, release, version bump, workflow, secret, or forbidden-path changes.

Verification

  • npx tsc --noEmit → 0 errors; npm run build → passed; node --test test/*.test.mjs → 445 pass / 0 fail.

Risk

  • Low: scoped TypeScript rename plus type annotations; behavior covered by existing config/util-adjacent tests.

Linked issue

Closes #51

Authority boundary

john-lomein did not merge, publish, release, dispatch workflows, change settings, force-push, rewrite history, or touch secrets.

Convert src/config.js -> src/config.ts and src/util.js -> src/util.ts with
full type annotations. Shared PersistedUserConfig interface moves to
src/types/index.ts, removing the duplicate local definition in router.ts.
Tests repointed from src/ to dist/ imports (pretest builds before test run).

Phase 3 of the staged TypeScript migration (#51).

Closes #51
@graphanov

Copy link
Copy Markdown
Owner Author

@codex review

@graphanov

Copy link
Copy Markdown
Owner Author

Status: ready for review on latest head.

Evidence:

  • Head d46c1d1 on forge/issue-51-config-util-typescript is mergeable/CLEAN; CI ci → pass; reviewThreads → 0; forbidden paths → none; local verification: npx tsc --noEmit → 0 errors, npm run build → passed, node --test test/*.test.mjs → 445 pass / 0 fail; Codex review trigger already posted for this head.

Next: Marking PR ready for review. Owner gate still required before merge/publish/release; no gated side effect taken.

@graphanov
graphanov marked this pull request as ready for review June 29, 2026 10:42
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: d46c1d1f94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@graphanov

Copy link
Copy Markdown
Owner Author

APPROVE JOHN-LOMEIN BUNDLE lazyglm-59-d46c1d1f: merge listed PRs only; do not publish.

@graphanov
graphanov merged commit a5e402c into main Jun 29, 2026
1 check passed
@graphanov
graphanov deleted the forge/issue-51-config-util-typescript branch June 29, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 3: Convert config + util to TypeScript (.js → .ts)

1 participant