Fix metrics generator panic when write_relabel_configs is set (#6396)… - #6455
Merged
Conversation
…#6399) The Prometheus dependency upgrade from v0.304.2 to v0.307.3 (PR prometheus/prometheus#16928) moved label name validation from a global to a per-config NameValidationScheme field on relabel.Config. This field must be initialized by calling Validate() before use, otherwise relabeling panics with "Invalid name validation scheme requested: unset". Tempo constructs RemoteWriteConfig programmatically rather than going through Prometheus's config.Load() path, so Validate() was never called. Call RemoteWriteConfig.Validate(model.UTF8Validation) once at startup in storage.Config.Validate(), which initializes NameValidationScheme on all write relabel configs before any tenant storage instances are created. Also fix a pre-existing bug in watchOverrides where cached state was updated before ApplyConfig succeeded, preventing retries on failure.
carles-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
February 13, 2026 14:41
electron0zero
approved these changes
Feb 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#6399)
The Prometheus dependency upgrade from v0.304.2 to v0.307.3 (PR
prometheus/prometheus#16928) moved label name validation from a global
to a per-config NameValidationScheme field on relabel.Config. This field
must be initialized by calling Validate() before use, otherwise
relabeling panics with "Invalid name validation scheme requested: unset".
Tempo constructs RemoteWriteConfig programmatically rather than going
through Prometheus's config.Load() path, so Validate() was never called.
Call RemoteWriteConfig.Validate(model.UTF8Validation) once at startup
in storage.Config.Validate(), which initializes NameValidationScheme on
all write relabel configs before any tenant storage instances are created.
Also fix a pre-existing bug in watchOverrides where cached state was
updated before ApplyConfig succeeded, preventing retries on failure.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]