Helm: set default memberlist rejoin_interval to 60s - #16332
Open
parrahex wants to merge 2 commits into
Open
Conversation
Without a rejoin interval, a member evicted from the gossip ring by a transient network fault never rejoins (dskit default is 0s) and keeps serving stale ring data until restarted. The Loki chart already sets rejoin_interval (90s). Fixes grafana#16254
Contributor
Signed commits report2 of 2 commits between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Sets
memberlist.rejoin_intervalto 60s in the chart's defaultstructuredConfig.With the dskit default (
0s, disabled), a member evicted from the gossip ring by a transient network fault never rejoins and keeps serving a stale ring view until it is restarted - see the linked issue for a production incident report. The Loki chart already setsrejoin_interval(90s).Which issue(s) this PR fixes or relates to
Fixes #16254
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.