validation/limits: remove name ValidationSchemeValue in favor of prometheus/common/model.ValidationScheme - #12505
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the local ValidationSchemeValue wrapper type in favor of using the direct model.ValidationScheme type from the prometheus/common/model package, following the merge of a related upstream PR.
- Removes the custom
ValidationSchemeValuetype and its implementation file - Updates all references to use
model.ValidationSchemedirectly - Removes associated test files for the wrapper type
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/validation/validation_scheme_value.go | Removes the custom ValidationSchemeValue wrapper type |
| pkg/util/validation/validation_scheme_value_test.go | Removes tests for the ValidationSchemeValue wrapper |
| pkg/util/validation/limits.go | Updates field type to use model.ValidationScheme directly |
| pkg/util/validation/limits_test.go | Updates test assertions to use model.ValidationScheme |
| pkg/distributor/validate_test.go | Updates test setup to use model.ValidationScheme |
| pkg/distributor/otel_test.go | Updates test setup to use model.ValidationScheme |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aknuds1
approved these changes
Aug 26, 2025
aknuds1
left a comment
aknuds1
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo the Copilot suggestion. Thanks!
…etheus/common/model.ValidationScheme
juliusmh
force-pushed
the
jmh/validation_scheme_flag_cleanup
branch
from
August 26, 2025 11:07
273271a to
ac1267c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes unnecessary
validation.ValidationSchemeValuebecause prometheus/common#807 was merged.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.