Allow primitive OTEL delta ingestion to be enabled - #11631
Conversation
c24d3f4 to
26fca3e
Compare
|
💻 Deploy preview deleted. |
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
c4a1e7f to
b4f3f64
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds an experimental flag to ingest raw OTLP delta metrics without conversion.
- Introduce
OTelNativeDeltaIngestionin limits, overrides, handler, and converter - Wire the new flag through tests, CLI help, JSON descriptor, and documentation
- Add
TestOTelDeltaIngestionto validate delta behavior
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/validation/limits.go | Add OTelNativeDeltaIngestion field and register the CLI flag |
| pkg/distributor/push_test.go | Add mock implementation for OTelNativeDeltaIngestion |
| pkg/distributor/otel.go | Extend OTLPHandlerLimits and conversionOptions to include delta flag |
| pkg/distributor/otel_test.go | New TestOTelDeltaIngestion covering allowed and disallowed cases |
| docs/sources/mimir/configure/configuration-parameters/index.md | Document the otel_native_delta_ingestion parameter |
| docs/sources/mimir/configure/about-versioning.md | Add experimental feature entry for delta ingestion |
| cmd/mimir/help-all.txt.tmpl | Add CLI help entry for -distributor.otel-native-delta-ingestion |
| cmd/mimir/config-descriptor.json | Add config descriptor for otel_native_delta_ingestion |
| CHANGELOG.md | Log the new experimental feature under [FEATURE] |
Comments suppressed due to low confidence (2)
docs/sources/mimir/configure/about-versioning.md:119
- The backticked flag is missing its leading hyphen. It should be
-distributor.otel-native-delta-ingestionto match other entries.
- `distributor.otel-native-delta-ingestion`
cmd/mimir/help-all.txt.tmpl:1428
- Align this flag's indentation with other entries (use a leading tab) so the CLI help output remains consistently formatted.
-distributor.otel-native-delta-ingestion
|
hey @fionaliao , we are currently exploring delta ingestion , we have enabled the flag for a tenant , dont see any errors while ingesting (can see errors like invalid temporality for other tenants) , but we dont see the data points either. Any idea what could be wrong ? We have dual write and the flag is not enabled for main tenant |
|
@arindampatra33 Please open an issue with some details about your setup and steps to reproduce if you suspect a bug. Thanks! |
What this PR does
This PR introduces the
-distributor.otel-native-delta-ingestionflag (and corresponding per-tenant setting), which enables primitive OTEL delta metrics ingestion via the OTLP endpoint. This feature was implemented in Prometheus in prometheus/prometheus#16360. This PR allows Mimir users to enable this feature too.As per the Prometheus PR:
Which issue(s) this PR fixes or relates to
An initial PR for #10439
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.