promlib: remove experimental schema/SQL-abstraction integration - #224
Draft
kylebrandt wants to merge 1 commit into
Draft
promlib: remove experimental schema/SQL-abstraction integration#224kylebrandt wants to merge 1 commit into
kylebrandt wants to merge 1 commit into
Conversation
Winds down the feature-gated schemads-based schema discovery and SQL->PromQL transpilation/pushdown added under the dsAbstractionApp experiment. The code was never enabled by default and had no user-facing effect. Removed: - pkg/promlib/sql.go (normalizeGrafanaSQLRequest, FOR-clause -> PromQL, wrapAggregation) - pkg/promlib/resource/schema.go (SchemaProvider, incl. per-metric metadata) - pkg/promlib/flatten.go (multi-frame -> tabular flattening) - schemads wiring in library.go and the TestSchemaProvider case in resource_test.go - github.com/grafana/schemads dependency (and its transitive deps) from both go.mod modules Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Winds down the experimental, feature-gated schemads-based schema discovery and SQL→PromQL transpilation/pushdown in promlib (added under the dsAbstractionApp experiment). It was never enabled by default and has no user-facing effect.
Effectively reverts
sql.go,resource/schema.go,flatten.go) and thelibrary.gowiring(Incidental touches to the removed files from non-abstraction PRs are also trimmed but those PRs are not reverted: #93 "decoding compressed responses" keeps its general
resource.go/utilswork — only itsSchemaProvideradditions + that one test go away; dependency bumps #69/#198 are superseded by removing the schemads dep.)Removed
pkg/promlib/sql.go—normalizeGrafanaSQLRequest, FOR-clause → PromQL,wrapAggregationpkg/promlib/resource/schema.go—SchemaProvider(incl. per-metric metadata)pkg/promlib/flatten.go— multi-frame → tabular flatteninglibrary.goand theTestSchemaProvidercase inresource_test.gogithub.com/grafana/schemadsdependency (and its transitive deps) from both go.mod modulesVerification
go build ./...+go test ./...pass in bothpkg/promliband the root moduleNote: downstream consumers (e.g. grafana/grafana, which pins
pkg/promlib) pick this up on the next promlib version bump.