feat: Part 2 - Expose knobs for OTel v0.158.0 upgrade - #6876
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
💻 Deploy preview available (feat: Part 2 - Expose knobs for OTel v0.158.0 upgrade): |
| } | ||
| } | ||
|
|
||
| func TestUniverseDomain(t *testing.T) { |
There was a problem hiding this comment.
So we add a bunch of these small tests in this pr.
Ideally we would have one or more test covering all setting for a component and not just these small specialized tests for properties that was just added, since we miss coverage for basically everything else. WDYT?
There was a problem hiding this comment.
yeah that's a good point, I was trying to keep it specific to these changes but makes sense to have tests grouped together
…sor - this is a no-op
3c50a8b to
765e005
Compare
|
|
||
| if args.AggregationTemporality == AggregationTemporalityDelta && args.TimestampCacheSize <= 0 { | ||
| return fmt.Errorf("invalid metric_timestamp_cache_size: %v, the cache size should be positive", args.TimestampCacheSize) | ||
| cfg, err := args.Convert() |
There was a problem hiding this comment.
we can actually just delegate to the upstream validation here, instead of duplicating it here - it's a pattern we use elsewhere in otel components in alloy
| | `project` | `string` | Google Cloud Platform project identifier. | Fetch from credentials | no | | ||
| | `timeout` | `Duration` | Timeout for calls to the Pub/Sub API. | `"12s"` | no | | ||
| | `universe_domain` | `string` | Universe domain for the Pub/Sub service. Set to support Sovereign Cloud regions. | `"googleapis.com"` | no | | ||
| | `user_agent` | `string` | Override the user agent string on requests to Cloud Monitoring. This only applies to metrics. Specify `{{version}}` to include the application version number. | `"opentelemetry-collector-contrib {{version}}"` | no | |
There was a problem hiding this comment.
| | `user_agent` | `string` | Override the user agent string on requests to Cloud Monitoring. This only applies to metrics. Specify `{{version}}` to include the application version number. | `"opentelemetry-collector-contrib {{version}}"` | no | | |
| | `user_agent` | `string` | Override the user agent string used for Pub/Sub requests. Specify `{{version}}` to include the application version number. | `"opentelemetry-collector-contrib {{version}}"` | no | |
Remove the Cloud Monitoring ref and the implication that this is metrics-only. (this is based on a Claude analysis which finds that it's referencing the wrong backend, and that stating metrics only implies a signal specific behaviour that the component does not expose)
3 participants
Brief description of Pull Request
Exposes some config now available upstream with the v0.153.0 -> v0.158 contrib bump
This PR covers a handful of components, there will be a couple other follow up PR's covering other components as well, I just didn't want to have one massive PR and break things out into reviewable chunks
Pull Request Details
otelcol.processor.k8sattributes => exposes
pod_delete_grace_period. This PR also fixes the converter, which wasn't mappingwatch_sync_periodotelcol.connector.spanmetrics => exposes
globon the dimension blockotelcol.exporter.file => exposes the
compression_paramsblockotelcol.receiver.awscloudwatch => exposes
initial_lookbackon the logs blockotelcol.receiver.googlecloudpubsub / otelcol.exporter.googlecloudpubsub =>
expose universe_domainon bothshared tls block => exposes
include_insecure_cipher_suites, which allowscipher_suitesto select suites Go considers insecure. It lives onTLSSetting, so it reaches every component with a client or server tls block, and is documented in the two shared doc snippets.PR Checklist