feature(monitors): Add Native Histogram for Monitors - #6817
Open
hdost wants to merge 1 commit into
Open
Conversation
Pod Monitors and Service Monitors have had the ability to individually configure Scraping of Native Histograms, but before this patch there was no way to force native histogram scrape for an individual service. This meant that for an entire cluster you had to choose to potentially send way more metrics all a once than you may want for a cluster.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
This adds the ability for individual
PodMonitors andServiceMonitors to chose whether ornot to ScrapeNativeHistograms. This means that for an entire cluster you no longer have to
choose to potentially send way more metrics all a once than you may want for a cluster.
Pull Request Details
Adds two basic flags passed through from PodMonitors to the Alloy Scrape Configurations. They already are supported, so no need to add more functionality.
Issue(s) fixed by this Pull Request
#6834
Notes to the Reviewer
Nothing much, perhaps
PR Checklist