Skip to content

Add weighted rubric MAE using metadata point values#1

Merged
andrewpbray merged 4 commits into
mainfrom
extend-metrics
May 26, 2026
Merged

Add weighted rubric MAE using metadata point values#1
andrewpbray merged 4 commits into
mainfrom
extend-metrics

Conversation

@andrewpbray

Copy link
Copy Markdown
Collaborator
  • Add scores_from_metadata() helper to extract rubric scores from JSON
  • Add weights argument to rubric_mae() and find_differences()
  • Update compute_mae_and_isp() to accept optional metadata_file
  • Add tests for weighted MAE and scores_from_metadata()

- Add scores_from_metadata() helper to extract rubric scores from JSON
- Add weights argument to rubric_mae() and find_differences()
- Update compute_mae_and_isp() to accept optional metadata_file
- Add tests for weighted MAE and scores_from_metadata()
Copilot AI review requested due to automatic review settings May 26, 2026 18:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for computing a point-weighted rubric MAE by using rubric item point values from a metadata JSON file, and exposes a helper to extract those scores for reuse across the package.

Changes:

  • Added scores_from_metadata() to read rubric point values from metadata JSON.
  • Extended rubric_mae() / find_differences() to accept optional weights for weighted MAE.
  • Updated compute_mae_and_isp() to optionally load weights from metadata_file, and added tests covering weighted MAE + metadata score extraction.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/testthat/test-computing-accuracy.R Adds tests for weighted MAE and scores_from_metadata().
R/computing-accuracy.R Implements scores_from_metadata(), threads weights through MAE computation, updates docs.
NAMESPACE Exports scores_from_metadata().
man/scores_from_metadata.Rd New generated documentation for scores_from_metadata().
man/rubric_mae.Rd Documents the new weights parameter and weighted behavior.
man/compute_mae_and_isp.Rd Documents new metadata_file parameter and weighted MAE behavior.
Files not reviewed (3)
  • man/compute_mae_and_isp.Rd: Language not supported
  • man/rubric_mae.Rd: Language not supported
  • man/scores_from_metadata.Rd: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/computing-accuracy.R Outdated
@andrewpbray andrewpbray merged commit 1925cb3 into main May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants