Add weighted rubric MAE using metadata point values#1
Merged
Conversation
andrewpbray
commented
May 26, 2026
Collaborator
- Add scores_from_metadata() helper to extract rubric scores from JSON
- Add weights argument to rubric_mae() and find_differences()
- Update compute_mae_and_isp() to accept optional metadata_file
- Add tests for weighted MAE and scores_from_metadata()
- Add scores_from_metadata() helper to extract rubric scores from JSON - Add weights argument to rubric_mae() and find_differences() - Update compute_mae_and_isp() to accept optional metadata_file - Add tests for weighted MAE and scores_from_metadata()
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for computing a point-weighted rubric MAE by using rubric item point values from a metadata JSON file, and exposes a helper to extract those scores for reuse across the package.
Changes:
- Added
scores_from_metadata()to read rubric point values from metadata JSON. - Extended
rubric_mae()/find_differences()to accept optionalweightsfor weighted MAE. - Updated
compute_mae_and_isp()to optionally load weights frommetadata_file, and added tests covering weighted MAE + metadata score extraction.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-computing-accuracy.R | Adds tests for weighted MAE and scores_from_metadata(). |
| R/computing-accuracy.R | Implements scores_from_metadata(), threads weights through MAE computation, updates docs. |
| NAMESPACE | Exports scores_from_metadata(). |
| man/scores_from_metadata.Rd | New generated documentation for scores_from_metadata(). |
| man/rubric_mae.Rd | Documents the new weights parameter and weighted behavior. |
| man/compute_mae_and_isp.Rd | Documents new metadata_file parameter and weighted MAE behavior. |
Files not reviewed (3)
- man/compute_mae_and_isp.Rd: Language not supported
- man/rubric_mae.Rd: Language not supported
- man/scores_from_metadata.Rd: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.