Skip to content

remove old handler#1

Open
turkosaurus wants to merge 1 commit into
mainfrom
turk/86handler
Open

remove old handler#1
turkosaurus wants to merge 1 commit into
mainfrom
turk/86handler

Conversation

@turkosaurus

@turkosaurus turkosaurus commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

out with the old custom implementation in favor of something already full featured (attrs, etc.)

recent improvements make this obsolete/undesireable

@turkosaurus
turkosaurus requested a review from Copilot June 9, 2025 05:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated custom logging handler and its associated tests in favor of the new full-featured implementation.

  • Removed obsolete tests from handler_test.go
  • Removed the old custom SlogHandler implementation and its initialization in handler.go

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
handler_test.go Removed tests for the old custom handler
handler.go Removed the old custom logging handler implementation and methods
Comments suppressed due to low confidence (2)

handler_test.go:1

  • The removal of tests for the old custom handler may leave a gap in verifying the new logging implementation. Please ensure that the new implementation is well covered by tests elsewhere.
package log

handler.go:1

  • The removal of the SlogHandler implementation requires confirming that all references to this handler and its initialization via Init are updated to use the new implementation. Double-check that no dependent code still relies on the removed functionality.
package log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants