remove old handler#1
Open
turkosaurus wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated custom logging handler and its associated tests in favor of the new full-featured implementation.
- Removed obsolete tests from handler_test.go
- Removed the old custom SlogHandler implementation and its initialization in handler.go
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| handler_test.go | Removed tests for the old custom handler |
| handler.go | Removed the old custom logging handler implementation and methods |
Comments suppressed due to low confidence (2)
handler_test.go:1
- The removal of tests for the old custom handler may leave a gap in verifying the new logging implementation. Please ensure that the new implementation is well covered by tests elsewhere.
package log
handler.go:1
- The removal of the SlogHandler implementation requires confirming that all references to this handler and its initialization via Init are updated to use the new implementation. Double-check that no dependent code still relies on the removed functionality.
package log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
out with the old custom implementation in favor of something already full featured (attrs, etc.)
recent improvements make this obsolete/undesireable