[newchem-cpp] WIP: initial efforts towards splitting SpLUT#551
Open
mabruzzo wants to merge 37 commits into
Open
[newchem-cpp] WIP: initial efforts towards splitting SpLUT#551mabruzzo wants to merge 37 commits into
SpLUT#551mabruzzo wants to merge 37 commits into
Conversation
mabruzzo
force-pushed
the
ncc/use-partmap
branch
3 times, most recently
from
cc469e9 to
47fb540
Compare
…data Currently, `time_deriv_0d` works by preparing a context pack with all of the infrastructure for creating a 1-element version of grackle_field_data. This was a pragmatic choice early during transcription, but it's hacky & inefficient. Before this PR: - the `time_derivative_0d::derivative` function would overwrite `pack.field.internal_energy` and `pack.field.e_density`, `pack.field.HI_density`, `pack.field.HII_density`, ... to point to the buffers provided in the function arguments - now, the context pack will pre-allocate the evolved buffers tracked within the 1-element version `grackle_field_data` and we will just copy over the values from the function arguments Aside: for all fields that aren't evolved (e.g. `density`, `dust_density`, `volumetric_heating_rate`, RT-fields, etc.) the 1-zone `grackle_field_data` instance just points to the appropriate location in the full 3D field.
This is inadvisable, but will be necessary to achieve reasonable performance in step_rate_newton_raphson
…sLUT::<name>_dust
mabruzzo
force-pushed
the
ncc/use-partmap
branch
from
da52b05 to
d1c37bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR (I will definitely modify it before it's ready for review)
This depends on #562
I'm posting it now to start running the tests in the background.