[newchem-cpp] Reorganize logic in cool1d_multi_g#547
Open
mabruzzo wants to merge 105 commits into
Open
Conversation
This switches to using GRIMPL_NAMESPACE_DECL and puts all the helper function into the namespace
The result is definitely not bitwise identical, but that's not going to make tests fail (since the logic is not tested)
It turns out that the value computed on CI and on my personal machine were -4031685600248.466 and -4031685600261.704. These values had a relative difference of ~ -3.3e-12, which slightly exceeded our tolerance (2e-12). Consequently, we just averaged the values
This tweak will help with the next PR in the sequence
It is now temporarily allocated inside of cool1d_multi_g (the plan is to pass in a buffer as an argument). The new temporary variable is now called `nelec_times_mH`
There's chance that this will require an update to the gold-standard
The refactored logic uses a for-loop (rather than explicitly listing each kind of grain species) and one less temporary buffer. This is going to affect the gold-standard.
…probably not affect edot)
…ing to change the gold-standard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #546 is merged
This PR reorders a bunch of logic within
cool1d_multi_g. The plan is to write a followup PR where I extract the dust-related logic from this function and fromlookup_cool_rates1d(we're ALMOST there).This PR is going to require an update to gold-standard.