Backport cmake tweaks#515
Open
mabruzzo wants to merge 4 commits into
Open
Conversation
The `--prefix` case wasn't being properly handled
I forgot that the order of arguments definitely matters
Essentially, problems started cropping up because toolchain::m wasn't properly declared within the CMake Package Config file. I worked around the issue by getting rid of the target
brittonsmith
approved these changes
Apr 28, 2026
brittonsmith
left a comment
brittonsmith
left a comment
Contributor
There was a problem hiding this comment.
As long as you think we're not introducing merge conflicts, I'm fine with merging this. Feel free to do so if you think this isn't a concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports some issues with the meta files created/installed by CMake in order to make integration easier with external applications.
The fundamental problem is that we don't regularly test these approaches. I'm ~95% done with implementing some automated tests for these approaches. Those tests will be introduced in a PR to newchem-cpp (this PR simply backports some of those bugfixes)