Skip to content

[newchem-cpp] more clang-tidy checks#466

Merged
mabruzzo merged 7 commits into
grackle-project:newchem-cppfrom
mabruzzo:ncc/more-clang-tidy-checks
Feb 28, 2026
Merged

[newchem-cpp] more clang-tidy checks#466
mabruzzo merged 7 commits into
grackle-project:newchem-cppfrom
mabruzzo:ncc/more-clang-tidy-checks

Conversation

@mabruzzo

Copy link
Copy Markdown
Collaborator

To be reviewed after #425 is merged.


This adds some new clang-tidy checks, and makes some fixes. It highlighted a few cases that we don't really care about (but its promising for looking at future code)

@mabruzzo mabruzzo added the testing test suite, regression tests, ci infrastructure label Dec 11, 2025
@mabruzzo mabruzzo changed the base branch from main to newchem-cpp December 11, 2025 21:50
@mabruzzo mabruzzo changed the base branch from newchem-cpp to main January 13, 2026 23:41
@mabruzzo mabruzzo changed the base branch from main to newchem-cpp January 13, 2026 23:41
@brittonsmith

Copy link
Copy Markdown
Contributor

@mabruzzo after merging with newchem-cpp it looks like there is an error coming from clang-tidy. Also, some interesting notes about assigning garbage or undefined values. Not sure if those are anything to be concerned about.

@brittonsmith

Copy link
Copy Markdown
Contributor

BTW, feel free to merge once fixed.

@mabruzzo mabruzzo merged commit 8780fad into grackle-project:newchem-cpp Feb 28, 2026
5 checks passed
@mabruzzo mabruzzo deleted the ncc/more-clang-tidy-checks branch February 28, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing test suite, regression tests, ci infrastructure

Projects

Development

Successfully merging this pull request may close these issues.

2 participants