[newchem-cpp] cleanup grackle::impl::gauss_seidel::update_fields_from_tmpdens#434
Open
mabruzzo wants to merge 8 commits into
Open
[newchem-cpp] cleanup grackle::impl::gauss_seidel::update_fields_from_tmpdens#434mabruzzo wants to merge 8 commits into
grackle::impl::gauss_seidel::update_fields_from_tmpdens#434mabruzzo wants to merge 8 commits into
Conversation
In more detail, the function previously known as grackle::impl::update_fields_from_tmpdens_gauss_seidel is now known as grackle::impl::gauss_seidel::update_fields_from_tmpdens
mabruzzo
added
the
refactor
This was referenced Oct 2, 2025
Contributor
|
This is producing fairly large differences in the metal-chemistry freefall tests. I think we need to take a closer look. I'm going to go back and make sure nothing has deviated from the last couple PRs I've merged. |
Collaborator
Author
|
The fact that an earlier commit was failing may indicate that there is a bug in this PR. It may make sense to punt on this for now |
Contributor
|
Ok, that sounds sensible. I bypass this one for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #425 has been merged
Basic Context
When I transcribed
step_rate_gin PR #425, I split the logic between 2 functions:grackle::impl::chemistry::species_density_updates_gauss_seidel(not touched in this PR)grackle::impl::update_fields_from_tmpdens_gauss_seidelThis PR cleans up the implementation of the latter function
Changes
This PR made the following changes:
grackle::impl::update_fields_from_tmpdens_gauss_seidelso that it's now calledgrackle::impl::gauss_seidel::update_fields_from_tmpdensgrackle::impl::gauss_seidelnamespace