Skip to content

[newchem-cpp] convert solve_chemistry.{c->cpp} and calculate_*.{c->cpp}#430

Merged
brittonsmith merged 11 commits into
grackle-project:newchem-cppfrom
mabruzzo:ncc/cppify
Dec 17, 2025
Merged

[newchem-cpp] convert solve_chemistry.{c->cpp} and calculate_*.{c->cpp}#430
brittonsmith merged 11 commits into
grackle-project:newchem-cppfrom
mabruzzo:ncc/cppify

Conversation

@mabruzzo

Copy link
Copy Markdown
Collaborator

This should be reviewed after #411 is merged


This is a lightweight PR where I converted the following c files to C++

  • solve_chemistry.c -> solve_chemistry.cpp
  • calculate_temperature.c -> calculate_temperature.cpp
  • calculate_pressure.c -> calculate_pressure.cpp
  • calculate_gamma.c -> calculate_gamma.cpp
  • calculate_dust_temperature.c -> calculate_dust_temperature.cpp
  • calculate_cooling_time.c -> calculate_cooling_time.cpp

I made some other light edits along the way. This should be quick and very easy to review.

@mabruzzo mabruzzo added the refactor internal reorganization or code simplification with no behavior changes label Sep 29, 2025
The compiler could not tell if the number_density variable was always
initialized. While I was fixing that, I lightly reworked some of the
code (I didn't touch the logic, only the formatting and locations of
declarations)
@brittonsmith brittonsmith merged commit d8e9466 into grackle-project:newchem-cpp Dec 17, 2025
5 checks passed
@mabruzzo mabruzzo deleted the ncc/cppify branch December 19, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor internal reorganization or code simplification with no behavior changes

Projects

Development

Successfully merging this pull request may close these issues.

2 participants