[newchem-cpp] cleanup lookup_cool_rate_1d part 1#415
Merged
brittonsmith merged 36 commits intoNov 14, 2025
Merged
Conversation
lookup_cool_rate_1d part 1lookup_cool_rate_1d part 1
5 tasks
Collaborator
Author
|
@brittonsmith, this should be ready to go |
brittonsmith
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shouldn't be reviewed until after #412 and #413 are merged
As part of this PR, I
lookup_cool_rate_1dinto a helper functiongr_opaque_storage::used_kcol_rate_indices:gr_opaque_storage::kcol_rate_tables, we now only initialize the "ordinary" reaction rates that we usegr_opaque_storage::used_kcol_rate_indices. The length of this list is tracked bygr_opaque_storage::n_kcol_rate_indicesgr_opaque_storage::used_kcol_rate_indices