[newchem-cpp] factor out scale_fields_dust#386
Merged
brittonsmith merged 5 commits intoSep 12, 2025
Merged
Conversation
…/scale_fields_dust
This was referenced Aug 20, 2025
This was referenced Sep 2, 2025
brittonsmith
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally proposed as brittonsmith#41
This should be reviewed after #385 has been merged
This factors out some the logic from
calc_tdust_3dfor scaling densities from comoving form to "proper" form (and back again). This consists of 3 parts:scale_fields_table(so that the new function could be put into the files)calc_tdust_3d.All in all, this is pretty simple.
Note
This PR probably changes the precise answer of the answer-tests (I had to convert a division to multiplication by an inverse). In other words, the answers drift a tiny, nominal amount. Back when I originally proposed this change (as brittonsmith#41) all of the tests still passed