[newchem-cpp] transcribe scale_fields_table#381
Merged
brittonsmith merged 4 commits intoSep 12, 2025
Merged
Conversation
mabruzzo
added
the
refactor
This was referenced Aug 20, 2025
brittonsmith
approved these changes
Sep 12, 2025
brittonsmith
left a comment
brittonsmith
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me and I'll merge it to keep things rolling, but here is one comment. Should we add OpenMP parallelization for this? The regular scale_fields has it. Generally speaking, I've noticed that we are not fully consistent on where we implement parallelism.
github-project-automation
Bot
moved this from Awaiting Review
to Done
in New Chemistry and C++ Transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally proposed as brittonsmith#35
This should be reviewed after PR #380 is merged.
This transcribes the
scale_fields_tableFortran subroutine. The function is incredibly small and simple, and is only called withincalc_temp_cloudy_g(which was transcribed in #380).