src/example/Makefile cleanup#311
Merged
brittonsmith merged 2 commits intoMay 7, 2025
Merged
Conversation
We will no longer get the following warnings whenever we build the examples ```sh Makefile:103: warning: overriding commands for target `clean' Make.config.targets:170: warning: ignoring old commands for target `clean' ```
brittonsmith
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did 2 things:
src/examples/Makefile.out-of-source. This was initially used as a workaround for testing CMake builds. But this became unnecessary in PR Tweaking code example tests #258 (I forgot to remove it then)src/examples/Makefileintosrc/examples/Make.config.targets(while creating the CMake build-system,). Back when I did that, I accidentally defined themake cleancommand twice. Ever since then, we'd get the following warning (any time we use amakecommand within thesrc/examplesdirectory:If you want, I could recombine
src/examples/Makefile&src/examples/Make.config.targets, but it doesn't seem too pressing.