[newchem-cpp] revert code examples#278
Merged
mabruzzo merged 1 commit intoMar 26, 2025
Merged
Conversation
mabruzzo
force-pushed
the
ncc-revert-code-examples
branch
from
0a79ec1 to
d5d52ad
Compare
mabruzzo
force-pushed
the
ncc-revert-code-examples
branch
from
d5d52ad to
c868891
Compare
brittonsmith
approved these changes
Mar 25, 2025
brittonsmith
left a comment
brittonsmith
left a comment
Contributor
There was a problem hiding this comment.
The tests are passing/failing in ways that I completely expected. This is all fine to me. I'm on board with #258, so whatever gets us there is ok. I will review that next so we can move this along. @mabruzzo, feel free to pull this in whenever, but if you want to wait until approval of #258, that's fine.
Collaborator
Author
I'm relieved to hear that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what we discussed in Issue #272 -- reverting the code-examples. The purpose of this is to see whether the tests pass.