Skip to content

CI: Add unit tests and CI support - #2

Closed
ljubon wants to merge 4 commits into
mainfrom
313-tfe-plan-bot-cicdautomated-testing---level-1---2
Closed

CI: Add unit tests and CI support#2
ljubon wants to merge 4 commits into
mainfrom
313-tfe-plan-bot-cicdautomated-testing---level-1---2

Conversation

@ljubon

@ljubon ljubon commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

Scope of this PR is:

  • add unit tests for root.go and server.go
  • add CI worklow with Build and Test jobs

CI workflow: https://github.com/gr-oss-devops/tfe-plan-bot/actions/runs/9366731075 🟢

https://github.com/G-Research/oss-portfolio-maturity/issues/313

@ljubon
ljubon marked this pull request as ready for review June 4, 2024 12:11
@ljubon
ljubon requested a review from pavlovic-ivan June 4, 2024 12:11

@pavlovic-ivan pavlovic-ivan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the mix of stuff done here, but i will approve it

@ljubon
ljubon requested a review from pavlovic-ivan June 4, 2024 12:31
@ljubon

ljubon commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator Author

I've removed the changes which are part of linting PR, sorry for confusion

ljubon added a commit that referenced this pull request Jun 4, 2024
@ljubon ljubon mentioned this pull request Jun 4, 2024
@ljubon
ljubon force-pushed the main branch 4 times, most recently from adc1a6a to 56d3f4e Compare June 4, 2024 13:23
@ljubon ljubon mentioned this pull request Jun 4, 2024
@ljubon

ljubon commented Jul 24, 2024

Copy link
Copy Markdown
Collaborator Author

PR oppened upstream
G-Research#35

@ljubon ljubon closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants