Add sensors to filters and add other missing filters#53
Merged
Conversation
…ers to recipes explorer sidebar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ac6c524 to
62aba7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highlight,shadow,color,sharpness,high_iso_nr,clarity) to the recipes explorer sidebar. These were stored asDecimalFieldin the DB but missing fromRECIPE_FILTER_FIELDS; a fix to theis_numericcheck ensures correct null exclusion and numeric sort order for decimal values.sensorfilter to both the recipes explorer and images gallery sidebars. Sensors are a M2M relation and required special-casing: faceted counts usedistinct=True, and the gallery filter applies the M2M lookup via a pk-subquery to avoid corrupting theCount("images")annotation. Recipes with no sensor assigned show as "Not assigned" (URL value:none).Notes
RECIPE_FILTER_FIELDSwas intentionally left unchanged — sensors are handled as a special case in the filter functions rather than as a simple field lookup._active_filters_from_request,_recipe_explorer_filters_from_request) were updated to readsensorsfrom the request, since it is not covered by theRECIPE_FILTER_FIELDSloop.{{ option.label|default:option.value }}to allow a display label that differs from the URL parameter value.