feat: add --col-axis for multi-column competitor charts (#220)#222
Open
fahimfaisaal wants to merge 2 commits into
Open
feat: add --col-axis for multi-column competitor charts (#220)#222fahimfaisaal wants to merge 2 commits into
fahimfaisaal wants to merge 2 commits into
Conversation
Place numeric CSV/JSON column names on a free group axis (n/x/y/z) so competitors share one chart instead of one chart per column. Expanded stats omit type; the UI falls back to the dataset name for the title. Also wire col-axis through the GitHub Action, add concurrency.csv example, and publish it via the CSV examples workflow (#220).
fahimfaisaal
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Export ensureInjectAxis as EnsureAxis (drop expand wrapper), drop empty early return, and add pipeline/expand tests for non-tabular skip, select-mode skip, z-axis validation, and nil stat values so patch coverage hits applyColAxis and ExpandStatsOntoAxis fully.
fahimfaisaal
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--col-axis/-Aso grouped CSV/JSON wide tables put numeric column names on a free axis (n/x/y/z) and share one chart instead of one chart per column.type(json:"type,omitempty"); the UI falls back to the dataset name (-n) for the chart title.col-axisthrough the GitHub Action, addsexamples/csv/concurrency.csv, and deploys it as10-concurrency-frameworksin the CSV examples workflow.Closes #220
Example
vizb bar examples/csv/concurrency.csv -g load -p y -A x -n "HTTP frameworks" -o out.htmlTest plan
go test ./...(pre-commit)concurrency.csv→ single chart, notypein stats JSON, axes include inject dimvizb-binaryif neededcol-axisforwards--col-axis