Skip to content

cl genClassProjectMain fix (flat): narg = 2#2805

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q
Jun 27, 2026
Merged

cl genClassProjectMain fix (flat): narg = 2#2805
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@fennoai

fennoai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

An internal error occurred. Please try again later.

View job run

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.22%. Comparing base (73a0393) to head (f6d71a1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2805   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files          32       32           
  Lines       10453    10454    +1     
=======================================
+ Hits         9849     9850    +1     
  Misses        431      431           
  Partials      173      173           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the genClassProjectMain function in cl/classfile.go to explicitly set narg = 2 within a conditional block. There are no review comments, and I have no additional feedback to provide on this change.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@xushiwei xushiwei merged commit d855433 into goplus:main Jun 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant