Skip to content

reflectx v1.7.0 icall replace map with slice#461

Merged
visualfc merged 1 commit into
goplus:mainfrom
visualfc:icall_slice
May 14, 2026
Merged

reflectx v1.7.0 icall replace map with slice#461
visualfc merged 1 commit into
goplus:mainfrom
visualfc:icall_slice

Conversation

@visualfc

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/goplus/reflectx dependency to version v1.6.5-0.20260514121618-6759824c2e5c in both go.mod and go.sum. I have no feedback to provide.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR bumps github.com/goplus/reflectx from stable v1.6.4 to pseudo-version v1.6.5-0.20260514121618-6759824c2e5c to pick up an internal performance optimization (replacing a map[int]*methodInfo with a slice in the icall trampoline provider).

The diff is mechanically correct: both the h1: content hash and the /go.mod hash for the new pseudo-version are present in go.sum, and the old v1.6.4 entries are retained as expected by the Go toolchain.

A couple of observations are noted inline.

Comment thread go.mod Outdated
Comment thread go.mod Outdated
@visualfc visualfc changed the title reflectx: icall replace map with slice reflectx v1.7.0 icall replace map with slice May 14, 2026
@visualfc visualfc merged commit d155409 into goplus:main May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant