Skip to content

test(codex): add real plugin lifecycle smoke#255

Merged
corylanou merged 1 commit into
mainfrom
detent/gopher-ai-gopherguides_gopher-ai_252-3f33d6fd1642
Jul 19, 2026
Merged

test(codex): add real plugin lifecycle smoke#255
corylanou merged 1 commit into
mainfrom
detent/gopher-ai-gopherguides_gopher-ai_252-3f33d6fd1642

Conversation

@corylanou

Copy link
Copy Markdown
Member

Summary

  • add a dedicated real-Codex 0.144.6 lifecycle job with an isolated home, local Git marketplace, and deterministic local Responses server
  • verify first-install SessionStart and Stop hooks, retain exact hook paths for a session active across an update, and verify a fresh post-update session
  • preserve already-published plugin roots across Codex marketplace reconciliation until explicit pruning

Validation

  • scripts/test-installation.sh
  • scripts/test-codex-plugin-lifecycle.sh with Codex 0.144.6
  • Bash syntax, shellcheck, and Python byte compilation for touched scripts
  • configured full Detent validation gate

Fixes #252

Exercise Codex 0.144.6 against an isolated local marketplace and Responses server for first-install and update sessions. Preserve published plugin roots across the CLI marketplace reconciliation so active hooks remain usable until explicit pruning.
@corylanou
corylanou merged commit ed6368a into main Jul 19, 2026
8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15b82ee09e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install-codex.sh
Comment on lines +488 to +489
rm -rf "${target_root:?}"
cp -R -p "$backup_root" "$target_root"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Skip restoring broken current cache roots

If a prior --user run was interrupted and left the current-version cache root incomplete, this restore path backs up that broken directory, lets codex plugin add recreate a good one, and then deletes the fresh target and copies the broken backup back over it. In that recovery scenario the installer exits successfully but the plugin remains missing files or executable hooks, so a normal rerun cannot heal the cache; only restore roots that were actually removed/superseded, or avoid overwriting an existing freshly installed target.

Useful? React with 👍 / 👎.

@corylanou
corylanou deleted the detent/gopher-ai-gopherguides_gopher-ai_252-3f33d6fd1642 branch July 19, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(codex): add a real first-session plugin lifecycle smoke test

1 participant