Skip to content

fix(codex): install global plugins through CLI#254

Merged
corylanou merged 2 commits into
mainfrom
detent/gopher-ai-gopherguides_gopher-ai_253-ed43d2394188
Jul 19, 2026
Merged

fix(codex): install global plugins through CLI#254
corylanou merged 2 commits into
mainfrom
detent/gopher-ai-gopherguides_gopher-ai_253-ed43d2394188

Conversation

@corylanou

Copy link
Copy Markdown
Member

Summary

  • Register or upgrade the gopher-ai marketplace through the supported Codex CLI and install all six Codex-capable plugins with codex plugin add.
  • Delegate plugin enablement and versioned cache publication to Codex while keeping explicit pruning safe for active and incomplete roots.
  • Publish synchronized 1.7.2 manifests and update global-install guidance for the public CLI flow.

Test Plan

  • Focused installation suite: passed, including first install, reinstall, upgrade, pruning, capability, and legacy cleanup coverage.
  • Detent pre-review validation gate: passed for commands, hooks, ship E2E, shared sync, shell, skill metadata, YAML, Go build, and Go tests.
  • Diff hygiene, shell syntax, and ShellCheck for touched scripts: passed.

Fixes #253

Delegate cache publication and config enablement to Codex's supported
plugin commands. Keep explicit pruning version-aware and publish 1.7.2.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01ed857acf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install-codex.sh
fi
echo " installed: $plugin_name (cached at $dest)"
echo "installing $plugin_name@gopher-ai..."
codex plugin add "${plugin_name}@gopher-ai" 2>&1 | sed 's/^/ /'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve cache roots when delegating installs

When users re-run --user while a Codex session is still alive, this codex plugin add call is not a no-op even for the same plugin version. I checked the upstream Codex CLI implementation (codex-rs/core-plugins/src/store.rs): PluginStore::install goes through replace_plugin_root_atomically, which replaces the whole plugin cache root when the target version already exists and removes older version directories when installing a new version. That invalidates the absolute hook/skill paths that this installer and docs promise to retain until --prune-cache; the previous implementation explicitly kept complete published roots instead of rewriting them.

Useful? React with 👍 / 👎.

@corylanou
corylanou merged commit 29437ec into main Jul 19, 2026
9 checks passed
@corylanou
corylanou deleted the detent/gopher-ai-gopherguides_gopher-ai_253-ed43d2394188 branch July 19, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(codex): install global plugins through codex plugin add

1 participant