fix(codex): install global plugins through CLI#254
Conversation
Delegate cache publication and config enablement to Codex's supported plugin commands. Keep explicit pruning version-aware and publish 1.7.2.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01ed857acf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
| echo " installed: $plugin_name (cached at $dest)" | ||
| echo "installing $plugin_name@gopher-ai..." | ||
| codex plugin add "${plugin_name}@gopher-ai" 2>&1 | sed 's/^/ /' |
There was a problem hiding this comment.
Preserve cache roots when delegating installs
When users re-run --user while a Codex session is still alive, this codex plugin add call is not a no-op even for the same plugin version. I checked the upstream Codex CLI implementation (codex-rs/core-plugins/src/store.rs): PluginStore::install goes through replace_plugin_root_atomically, which replaces the whole plugin cache root when the target version already exists and removes older version directories when installing a new version. That invalidates the absolute hook/skill paths that this installer and docs promise to retain until --prune-cache; the previous implementation explicitly kept complete published roots instead of rewriting them.
Useful? React with 👍 / 👎.
Summary
codex plugin add.Test Plan
Fixes #253