Adds the following feature.#93
Conversation
| User user = new User(keyString, name, profilePicKey); | ||
| followerUsers.add(user); | ||
| } catch(EntityNotFoundException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
If a user's key isn't found (maybe the user's account was deleted or something), then this try-catch will completely interrupt the servlet and return no followers to the user. I think this behavior can be improved with a continue statement, so the problematic user is skipped, but the loop still gets all the other value users.
There was a problem hiding this comment.
I think it also might be better to run a query on Datastore users as opposed to iterating through a loop of keys and getting user data (I think individual calls to separate APIs are costly).
|
|
||
| User user = new User(keyString, name, profilePicKey); | ||
| usersFollowed.add(user); | ||
| } catch(EntityNotFoundException e) { |
There was a problem hiding this comment.
if possible, please auto-reformat before submitting. There are a lot of small formatting inconsistencies.
adamtcohen
left a comment
adamtcohen
left a comment
There was a problem hiding this comment.
Did a very quick review for major issues since it is the last day.
4 participants
No description provided.