This repository was archived by the owner on Jul 24, 2023. It is now read-only.
New message: front-end#69
Open
tgomezzzz wants to merge 2 commits into
Open
Conversation
angplee
reviewed
Jul 17, 2020
| return "<p>" + content + "</p>"; | ||
| } | ||
|
|
||
| function newGroupchat() { |
Contributor
There was a problem hiding this comment.
GroupChat >:(
jk do what u want hehe just suggestion
idk u said before you'd change to just "Group" or smth but since group is its own thing i guess not
would be nice to also change Groupchat --> GroupChat 4 the class
Contributor
There was a problem hiding this comment.
I prefer Groupchat, since it is just one word.
| const key = urlParams.get('key'); | ||
| fetch('/load-groupchat?key=' + key).then(response => response.json()) | ||
| .catch(error => { | ||
| alert('Error: Groupchat does not exist'); |
| window.location.href = 'index.html'; | ||
| }).then((messages) => { | ||
| const messageContainer = document.getElementById('messages'); | ||
| messageContainer.innerHTML = ''; |
Contributor
There was a problem hiding this comment.
Does this have a script injection concern :0
Contributor
Author
There was a problem hiding this comment.
I'm not entirely sure, but I don't think so because the message's innerText is set, and not its innerHTML. I'm not sure if this makes it safe of a script injection though
Rmoneygit
approved these changes
Jul 22, 2020
angplee
approved these changes
Jul 30, 2020
adamtcohen
approved these changes
Aug 4, 2020
vidhyal
approved these changes
Aug 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This quick PR adds the input for typing new messages and fixes a bug in the fetch() statement.