[fea-rs] Accept valueRecordDef inside feature and lookup blocks#2016
Merged
Conversation
The spec says valueRecordDef is a top-level statement, but feaLib has always accepted it inside feature and lookup blocks, and real fonts use this (e.g. Google Sans Arabic defines DOT_SHIFT inside a feature block). Accept it for feaLib compatibility. Part of #2014.
c989b10 to
61b0ed9
Compare
rsheeter
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FEA spec says
valueRecordDefis a top-level-only statement, but feaLib has accepted it inside feature and lookup blocks since valueRecordDef was first implemented (fonttools/fonttools@c06a377aa, Aug 2015), it was never limited to top-level scope. And as we found out today, real fonts rely on this: e.g. Google Sans Arabic defines a named value record inside a feature block:This adds
valueRecordDefhandling to the parser, validator, and compiler for feature/lookup block scope.Part of #2014.