[ufo] Use codepoints declared in default glyph instance#2006
Merged
Conversation
Instead of taking the union of all codepoints assigned to all instances, which in some cases would cause us to fail to compile due to a Cmap conflict, if one instance happened to have an incorrect or out of date codepoint entry. We will now warn if there is a codepoint conflict, but will not fail to compile.
anthrotype
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finishing up a last WIP from the weekend: this fixes another crater crash.
Instead of taking the union of all codepoints assigned to all instances, which in some cases would cause us to fail to compile due to a Cmap conflict, if one instance happened to have an incorrect or out of date codepoint entry that was also assigned to another glyph.
We will now warn if there is a codepoint conflict, but will not fail to compile.