Refactor: parameterize SQL query values#212
Open
dihenker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates query construction to use parameterized values instead of embedding values directly into SQL strings.
Previously, some queries injected values using Python f-strings. This lead to malformed SQL when values contained characters that require escaping (e.g. single quotes in strings). By using query parameters, value escaping and binding are delegated to the database driver.
Motivation
A concrete example is a value such as:
When embedded directly into a query string, the resulting SQL can become invalid because the single quote terminates the string literal prematurely. This was the case during deletion of nodes from vector and doc stores.
Using parameterized queries allows these values to be handled correctly without manual escaping and reduces the risk of SQL injection vulnerabilities.
Changes
__afetch_queryto accept query params.Notes
This change only parameterizes query values.
Table names, column names, and other SQL identifiers are still dynamically constructed where required, as database parameterization mechanisms generally do not support binding identifiers. Existing handling of dynamic identifiers remains unchanged.
Benefits