test(spanner): add more integration tests for read-only transactions#5729
Merged
olavloite merged 2 commits intoMay 25, 2026
Merged
Conversation
Adds more integration tests for read-only transactions.
sakthivelmanii
approved these changes
May 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5729 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 226 226
Lines 55691 55691
=======================================
+ Hits 54512 54514 +2
+ Misses 1179 1177 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for Spanner read-only transaction options, covering various timestamp bounds and read timestamp availability scenarios. The review feedback suggests using the server's current time instead of SystemTime::now() to avoid test flakiness caused by clock skew and recommends simplifying complex assertion logic in the tests to improve clarity and reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more integration tests for read-only transactions.