Fix xls codegen for extension ops#4437
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Conversation
Added checks in Op::kZeroExt and Op::kSignExt handling. If the input and output widths are the same (identity extension), the generator now returns the input expression directly. This avoids generating invalid 0'h0 literals (for zero-extension) or 0-replication (for sign-extension). PiperOrigin-RevId: 934986596
copybara-service
Bot
force-pushed
the
test_934986596
branch
from
ab38204 to
efe4ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix xls codegen for extension ops
Added checks in Op::kZeroExt and Op::kSignExt handling. If the input and output
widths are the same (identity extension), the generator now returns the input
expression directly. This avoids generating invalid 0'h0 literals (for
zero-extension) or 0-replication (for sign-extension).