Adding option to pass a vector of tops to optimizeUsingXls.#4436
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Adding option to pass a vector of tops to optimizeUsingXls.#4436copybara-service[bot] wants to merge 1 commit into
tops to optimizeUsingXls.#4436copybara-service[bot] wants to merge 1 commit into
Conversation
- Before: `optimizeUsingXls` took as top either the module name (when the module is named) or defaulted to `_package`, which triggers an error if not func inside module is named like that. This design was problematic in the context of broader code optimization when we typically want to extract multiple structures, optimize them with XLS, and inline the resulting optimization back into the original structures. Two work arounds were explored: i) wrapping all extracted funcs into the same module, but didn't work (as optimized functions couldn't be inlined back into their original structure), ii) wrapping each extracted func inside its own module, but possibly costly to run. - current proosal: passing a list of tops to `optimizeUsingXls` to call `mlirXlsToXls` over the entire module, and then loop over tops for `OptimizeIrForTop` and `XlsToMlirXlsTranslate` PiperOrigin-RevId: 934791923
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding option to pass a vector of
topstooptimizeUsingXls.optimizeUsingXlstook as top either the module name (when the module is named) or defaulted to_package, which triggers an error if not func inside module is named like that. This design was problematic in the context of broader code optimization when we typically want to extract multiple structures, optimize them with XLS, and inline the resulting optimization back into the original structures. Two work arounds were explored: i) wrapping all extracted funcs into the same module, but didn't work (as optimized functions couldn't be inlined back into their original structure), ii) wrapping each extracted func inside its own module, but possibly costly to run.optimizeUsingXlsto callmlirXlsToXlsover the entire module, and then loop over tops forOptimizeIrForTopandXlsToMlirXlsTranslate