[opt] Support lifting operations through OneHotSelect#4394
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[opt] Support lifting operations through OneHotSelect#4394copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_930781718
branch
from
11a0bb1 to
23692c5
Compare
This change introduces safety checks for lifting operations through OneHotSelect based on whether the operation preserves zero and distributes over bitwise OR. This allows more aggressive optimization of OneHotSelect nodes while maintaining correctness. If the OneHotSelect's selector might be zero, lifting the operation is only safe if the operation preserves zero; i.e., replacing input X by 0 makes the output 0. If the OneHotSelect's selector might have more than one bit set, lifting the operation is only safe if the operation distributes over bitwise OR; i.e., f(replace input X with A | B) produces the same result as replacing the result with f(replace input X with A) | f(replace input X with B). PiperOrigin-RevId: 930781718
copybara-service
Bot
force-pushed
the
test_930781718
branch
from
23692c5 to
5a36384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[opt] Support lifting operations through OneHotSelect
This change introduces safety checks for lifting operations through OneHotSelect based on whether the operation preserves zero and distributes over bitwise OR. This allows more aggressive optimization of OneHotSelect nodes while maintaining correctness.
If the OneHotSelect's selector might be zero, lifting the operation is only safe if the operation preserves zero; i.e., replacing input X by 0 makes the output 0.
If the OneHotSelect's selector might have more than one bit set, lifting the operation is only safe if the operation distributes over bitwise OR; i.e., f(replace input X with A | B) produces the same result as replacing the result with f(replace input X with A) | f(replace input X with B).