Skip to content

xls: fix dslx typos#2387

Closed
copybara-service[bot] wants to merge 85 commits into
mainfrom
test_770645332
Closed

xls: fix dslx typos#2387
copybara-service[bot] wants to merge 85 commits into
mainfrom
test_770645332

Conversation

@copybara-service

Copy link
Copy Markdown

xls: fix dslx typos

COPYBARA_INTEGRATE_REVIEW=#2296 from antmicro:zstd_compressed_block_dec_dslx_part 484cc69
FUTURE_COPYBARA_INTEGRATE_REVIEW=#2296 from antmicro:zstd_compressed_block_dec_dslx_part 484cc69

lpawelcz and others added 30 commits June 12, 2025 07:35
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Remove references to buffer structs as those are not used anywhere

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Krzysztof Oblonczek <koblonczek@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#67096]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Krzysztof Obłonczek <koblonczek@antmicro.com>
Signed-off-by: Krzysztof Obłonczek <koblonczek@antmicro.com>
Internal-tag: [#66955]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
* Fix byte ordering when receiving a series of non-empty packets
* Adjust MemReader DSLX tests

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
…es function into a separate proc

* Extract the operation of removing not-strobed bytes from input frames
  to a separate proc
* Extract control logic to AxiStreamRemoveEmptyInternal proc
* Optimize strobe calculation

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Fix paramaterization of the proc

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
…ackets

Add AxiStreamRemoveEmpty proc to the processing pipeline. It removes non-strobed
bytes from the input AXI Stream frames and forms full frames (ensures that only
the last input data packet won't be full).

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
* Extract control logic to MemWriterInternal proc
* Create alias for the MemWriter response type

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
SequenceExecutor:
  * Add output channel in the format compliant with MemWriter input data channel type

ZstdDecoder:
  * Add MemWriter proc:
    * Write request formed based on the address of the OutputBuffer CSR and
      FrameContentSize field from the Frame Header
    * Data to write is sent out to the proc by the SequenceExecutor
  * Transition to the FINISH state (and triggers notify channel) only after
    receiving the response from the MemWriter
  * DSLX tests:
    * Receive decoded data sent out on the AXI interface by the MemWriter proc
    * Mock the output memory buffer as a DSLX array

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
* Remove Repacketizer proc
* Remove stream-based output channels from
  * SequenceExecutor
  * ZstdDecoder

Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Internal-tag: [#67272]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
…on for verilog library

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
…atus enums

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
koblonczek and others added 29 commits June 12, 2025 07:35
Co-authored-by: Krzysztof Obłonczek <koblonczek@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#71874]
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Krzysztof Obłonczek <koblonczek@antmicro.com>
Signed-off-by: Maciej Torhan <mtorhan@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
* Use materialize_internal_fifos when possible
* Disable the above option for procs with loopback channels
* Add missing module names
* Add xls_fifo_wrapper verilog dependency to the synthesis of the procs without materialized internal fifos

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Wojciech Sipak <wsipak@antmicro.com>
No longer applicable - there are no CC tests in ZSTD module

Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
Improve formatting, wording and fix lint issues

Co-authored-by: Dominik Lau <dlau@antmicro.com>
Co-authored-by: Szymon Gizler <sgizler@antmicro.com>
Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
Co-authored-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Co-authored-by: Krzysztof Obłonczek <koblonczek@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Let's use predefined data first and only then add
zstd as dependency.

Signed-off-by: Wojciech Sipak <wsipak@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
The CI setup for the zstd module uses a bazel query to find groups of targets
that share a common suffix. By appending `_skip` to a target name,
the query no longer matches it, effectively excluding that target from the CI run.

Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Make Bazel queries stricter so that target names must end exactly with
the specified suffix, without allowing any additional characters after it.

Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@proppy proppy closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants