Skip to content

modules/zstd: Add support for decoding compressed blocks (DSLX part) #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wsipak wants to merge 83 commits into from
Closed

modules/zstd: Add support for decoding compressed blocks (DSLX part) #2230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
70b8036
modules/zstd/BUILD: increase pipeline_stages for DecoderMux proc
lpawelcz Nov 12, 2024
f5dc1a4
modules/zstd: Remove MagicNumberDecoder
lpawelcz Oct 8, 2024
9ae56af
modules/zstd: Remove BlockDecoder proc
lpawelcz Oct 8, 2024
e56535d
modules/zstd: Remove DecDemux proc
lpawelcz Oct 8, 2024
5bfc054
modules/zstd/block_header: Specify new type for the block size
m-torhan Oct 3, 2024
c2d91af
modules/zstd: Cleanup BlockHeader
lpawelcz Oct 8, 2024
da8680e
modules/zstd/BUILD: Introduce common codegen args
lpawelcz Oct 9, 2024
bfce022
modules/zstd: Add AxiCsrAccessor
lpawelcz Oct 8, 2024
f4335a6
modules/zstd: Add CsrConfig
m-torhan Oct 8, 2024
66460cf
modules/zstd: Add FrameHeaderDecoder
koblonczek Oct 8, 2024
3becd17
modules/zstd: Add BlockHeaderDecoder
m-torhan Oct 8, 2024
faa5a52
modules/zstd: Add RawBlockDecoder
m-torhan Oct 8, 2024
deda72e
modules/zstd: Add RleBlockDecoder
m-torhan Oct 8, 2024
f9584e2
modules/zstd: Add ZstdDecoder
rw1nkler Oct 8, 2024
a104936
modules/zstd: Update documentation
lpawelcz Oct 10, 2024
029c45b
modules/zstd: Add AxiRamReader implementation
m-torhan Aug 30, 2024
25e81e5
Adjust to changes in toolchain
koblonczek May 12, 2025
bfb91d5
modules/zstd/zstd_dec: Add DSLX tests for ZstdDecoder
koblonczek May 13, 2025
08f5c1a
modules/zstd/zstd_dec: handle contents of the Status CSR
lpawelcz Oct 22, 2024
44246e1
modules/zstd/data_generator: fix formatting
lpawelcz Nov 18, 2024
cac7396
modules/zstd/memory:axi_stream_remove_empty: Fix byte ordering
lpawelcz Oct 29, 2024
0b1a796
modules/zstd/memory/axi_stream_remove_empty: Extract remove_empty_byt…
lpawelcz Nov 4, 2024
7b731e5
modules/zstd/memory/axi_writer: Assign parameterized max lane value
lpawelcz Nov 13, 2024
b50bff6
modules/zstd/memory/mem_writer: Add support for not-full input data p…
lpawelcz May 12, 2025
9ec3ac5
modules/zstd/memory/mem_writer: Add MemWriterInternal proc
lpawelcz May 12, 2025
8729690
modules/zstd/zstd_dec: Write decoded data to the memory
lpawelcz May 13, 2025
8c305af
modules/zstd/zstd_dec: Remove stream-based output interface
lpawelcz May 12, 2025
71f4be6
modules/zstd/README: Update output interface description
lpawelcz Nov 19, 2024
e9dba15
modules/zstd/memory/axi_stream_remove_empty: add fifo module definiti…
lpawelcz Dec 31, 2024
dc94b5e
modules/zstd/zstd_dec: use regular cast instead of checked_cast on st…
lpawelcz Jan 13, 2025
e2776d6
modules/zstd: express data length in bytes
lpawelcz Nov 28, 2024
99ab9f6
modules/zstd: Add buffer implementing desired API
rw1nkler May 16, 2024
bd507cf
modules/zstd: Add FSE procs
rw1nkler May 16, 2024
cb92344
modules/zstd: Add a proc handling RAM write completion
rw1nkler May 16, 2024
70e6016
modules/zstd: Add Sequence and Literals Section Header decoders
rw1nkler Oct 31, 2024
29df5d9
modules: Add ShiftBuffer and RefillingShiftBuffer implementation
koblonczek Apr 16, 2024
c7f45f7
modules/zstd: Add FSE tables and lookup decoder
koblonczek Nov 13, 2024
844e1fb
modules/zstd: Add CommandConstructor proc
RRozak Apr 24, 2024
e64817c
modules/zstd: Add Ram demux
rw1nkler Apr 25, 2024
5536ea4
modules/zstd: Add literals decoding
m-torhan May 10, 2024
82eb0b2
modules/zstd: Add Huffman literals decoder
m-torhan Nov 19, 2024
c28e23a
modules/zstd: Add triple output RamDemux
rw1nkler Dec 12, 2024
78fc1ec
Add skeleton of SequenceDecoder
rw1nkler Dec 12, 2024
a4d8fa7
modules/zstd: Rework literals decoding to memory-based architecture
lpawelcz Dec 3, 2024
28112ef
modules/zstd/BUILD: tag targets as manual
rw1nkler Jan 14, 2025
e1a24f2
modules/zstd: Enable CompressedBlockDecoder
koblonczek Jan 14, 2025
520d819
modules/zstd: Enable CompressedBlockDecoder in ZstdDecoder
koblonczek May 12, 2025
0c1c493
modules/zstd: Add example frame for DSLX tests
rw1nkler Jan 14, 2025
567b5b8
modules/zstd: Adjust SequenceExecutor
rw1nkler Jan 14, 2025
04aee5b
modules/zstd: Adjust AxiRam
rw1nkler Jan 14, 2025
ccd719e
modules/zstd: Add RamMux
rw1nkler Jan 14, 2025
d91fafc
modules/zstd: Fix HuffmanRawWeightsDecoder
m-torhan Jan 7, 2025
67c7d50
Fix decoding multiple frames
rw1nkler Jan 16, 2025
5b3ec3a
Add support for Compressed FSE tables
koblonczek Jan 8, 2025
080fcce
Add test frame for compressed fse tables
rw1nkler Jan 16, 2025
bd47b3f
modules/zstd/zstd_dec: don't use channel arrays for FSE tables access
lpawelcz Jan 20, 2025
ba12ae9
Fix sequence decoding with predefined offset table, add regression test
koblonczek Jan 20, 2025
eb3b161
Add support for RLE and Repeated fse tables
rw1nkler Jan 22, 2025
9aa5952
Add test frame for repeated and rle tables
rw1nkler Jan 22, 2025
1d100b8
modules/zstd: Add RamMerge proc
lpawelcz Jan 22, 2025
006d196
modules/zstd: Implement HuffmanFseWeightsDecoder
m-torhan Jan 17, 2025
b6c82d0
Count the length of the section with probability frequencies
rw1nkler Jan 24, 2025
89ed30b
Adjust the design to the changed HuffmanWeightsDecoder
rw1nkler Jan 24, 2025
9da70d7
Remove duplicate fifo.v file
rw1nkler Jan 29, 2025
b0d7b3d
Move test files to a separate directory
rw1nkler Jan 29, 2025
afff2f7
Move shift_buffer to zstd directory
rw1nkler Jan 29, 2025
53d5b9f
Adjust BUILD files to the recent changes in the toolchain
rw1nkler Mar 26, 2025
a1316ba
Adjust design to the recent changes in the toolchain
rw1nkler Mar 26, 2025
399aa51
xls/modules/zstd/BUILD: Format with buildifer
lpawelcz Apr 7, 2025
358fbd4
xls/modules/zstd/memory/BUILD: Format with buildifer
lpawelcz Apr 7, 2025
706222b
modules/zstd/memory: Add missing module names
lpawelcz Apr 8, 2025
4b46ae3
modules/zstd: Rename axi_ram->axi_ram_reader
lpawelcz Apr 8, 2025
902a3ec
modules/zstd: Remove RESET CSR
lpawelcz May 12, 2025
612a53e
modules/zstd: fix bazel targets
lpawelcz Apr 8, 2025
9049a30
CI/modules-zstd: Remove step for running CC tests
lpawelcz Apr 9, 2025
44be57f
modules/zstd: add license
wsipak May 13, 2025
270983c
Style changes
wsipak May 20, 2025
d12c7d7
add targets for generating test frames
wsipak May 21, 2025
9b82ee9
Bump zstd
rw1nkler May 23, 2025
b5c4855
Add "pytype binary, library" hint
sgizler May 23, 2025
df06b50
Rename *.v to *.sv
sgizler May 23, 2025
8f93fcc
remove data generation with decodecorpus
wsipak May 29, 2025
54b5d01
Fix type checking in huffman_prescan.x
rw1nkler May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/modules-zstd.yml
View file
Open in desktop

@proppy proppy May 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump the timeout?

@rw1nkler rw1nkler May 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bumping the PR we noticed that some targets become longer then expected.
We are working on fixing that

Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ jobs:
run: |
bazel test -c opt --test_output=errors -- $(bazel query 'filter(".*_dslx_test", kind(rule, //xls/modules/zstd/...))')

- name: Test ZSTD Module - CC Tests (opt)
Comment thread
proppy marked this conversation as resolved.
if: ${{ !cancelled() }}
run: |
bazel test -c opt --test_output=errors -- $(bazel query 'filter(".*_cc_test", kind(rule, //xls/modules/zstd/...))')

- name: Build ZSTD verilog targets (opt)
if: ${{ !cancelled() }}
run: |
Expand Down
Loading
Loading