bugfix: examples/ram: 1R1W - fix missing mask expansion#1078
Merged
copybara-service[bot] merged 3 commits intoAug 21, 2023
Conversation
This was referenced Jul 25, 2023
Member
Can we add a test that capture this? |
Contributor
Author
|
Added two things:
|
Signed-off-by: Roman Dobrodii <rdobrodii@antmicro.com>
Initialization check did not work properly with masked reads when more partitions have been initialized than the read actually requested. Added test for masked reads and writes when NUM_PART != DATA_WIDTH. Signed-off-by: Roman Dobrodii <rdobrodii@antmicro.com>
Simplify & clean up code checking for initialization. Signed-off-by: Roman Dobrodii <rdobrodii@antmicro.com>
rdob-ant
force-pushed
the
47201-dpram-mask-bugfix
branch
from
95f32cc to
fe36cc3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code does not perform mask width expansion when processing read requests. As a result, configurations with
NUM_PARTITIONS != DATA_WIDTHfail to compile.