The WeightSynchronizer FFI derived the host staging slot as shard_idx % num_shards, which only works if a slice's device ordinals are contiguous and aligned to a multiple of num_shards. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checked logical_shard_idx input instead of deriving it from the device ordinal.#385
Open
copybara-service[bot] wants to merge 1 commit into
Open
The WeightSynchronizer FFI derived the host staging slot as shard_idx % num_shards, which only works if a slice's device ordinals are contiguous and aligned to a multiple of num_shards. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checked logical_shard_idx input instead of deriving it from the device ordinal.#385copybara-service[bot] wants to merge 1 commit into
shard_idx % num_shards, which only works if a slice's device ordinals are contiguous and aligned to a multiple of num_shards. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checked logical_shard_idx input instead of deriving it from the device ordinal.#385copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_951205209
branch
from
July 21, 2026 03:30
30a60f6 to
60aa813
Compare
copybara-service
Bot
changed the title
shard_idx % num_shards, which only works if a slice's device ordinals are contiguous and aligned to a multiple of num_shards. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checked logical_shard_idx input instead of deriving it from the device ordinal.
…x % num_shards`, which only works if a slice's device ordinals are contiguous and aligned to a multiple of `num_shards`. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checked `logical_shard_idx` input instead of deriving it from the device ordinal. PiperOrigin-RevId: 951205209
copybara-service
Bot
force-pushed
the
test_951205209
branch
from
July 21, 2026 03:30
60aa813 to
c027ed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WeightSynchronizer FFI derived the host staging slot as
shard_idx % num_shards, which only works if a slice's device ordinals are contiguous and aligned to a multiple ofnum_shards. Device ordinals are not guaranteed to be, so pass the staging slot explicitly as a range-checkedlogical_shard_idxinput instead of deriving it from the device ordinal.