Fix locale restoration for email reports.#13147
Open
techanvil wants to merge 6 commits into
Open
Conversation
📦 Build files for 6a3eeb8:
🎭 Playwright reports for 6a3eeb8: |
techanvil
commented
Jul 21, 2026
|
|
||
| $sections = $this->build_sections_for_log( $email_log, $user, $raw_payload ); | ||
| $user_locale = get_user_locale( $user ); | ||
| $switched_locale = switch_to_locale( $user_locale ); |
Collaborator
Author
There was a problem hiding this comment.
The changes specced in the IB didn't fix the issue - translations also occur via the methods Email_Template_Formatter::build_template_payload() and Email_Report_Sender::send().
Moving locale switching and restoration to Email_Log_Processor::process() is a correct fix for the issue.
techanvil
changed the title
techanvil
commented
Jul 21, 2026
| * @param Email_Report_Data_Section_Part[] $sections Built section parts. | ||
| * @return array | ||
| */ | ||
| private function to_sections_payload( array $sections ) { |
Collaborator
Author
There was a problem hiding this comment.
These methods were unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
The changes specced in the IB didn't fix the issue - translations also occur via the methods
Email_Template_Formatter::build_template_payload()andEmail_Report_Sender::send().Moving locale switching and restoration to
Email_Log_Processor::process()is a correct fix for the issue.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist