Skip to content

Add PageSpeed details link URL selector#13142

Open
Solaris-star wants to merge 1 commit into
google:developfrom
Solaris-star:enhancement/10870-pagespeed-details-link
Open

Add PageSpeed details link URL selector#13142
Solaris-star wants to merge 1 commit into
google:developfrom
Solaris-star:enhancement/10870-pagespeed-details-link

Conversation

@Solaris-star

Copy link
Copy Markdown

Summary

Addresses issue:

Relevant technical choices

  • Add a PageSpeed Insights getDetailsLinkURL selector that reuses getServiceURL.
  • Build the PageSpeed report URL with the reference site URL and the existing utm_source=sitekit parameter.
  • Add datastore coverage for the report path and both query parameters.

Testing

  • npx jest --config=jest.config.js --runInBand --selectProjects="Site Kit" --testMatch="<rootDir>/assets/js/modules/pagespeed-insights/datastore/service.test.js" — 5 tests passed.
  • npm run lint:js:files -- assets/js/modules/pagespeed-insights/datastore/service.js assets/js/modules/pagespeed-insights/datastore/service.test.js — passed.
  • git diff --check — passed.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Signed-off-by: Solaris-star <820622658@qq.com>
@google-cla

google-cla Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant