Rename AnalyticsActivationErrorNotification to InitialSetupErrorNotification#13139
Open
faisalahammad wants to merge 1 commit into
Open
Conversation
…ication The component is shown for any initial setup error, not only Analytics activation, so the new name describes its purpose better. - Rename component and stories file. - Update import, component name, constant, notification ID, and CSS class in SetupUsingProxyWithSignIn/index.js. - Update story usage and test descriptions. - Rename 6 Backstop reference PNGs (pixels unchanged).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue: #13046
Relevant technical choices
Rename
AnalyticsActivationErrorNotificationtoInitialSetupErrorNotificationand the matchingANALYTICS_ACTIVATION_ERROR_NOTIFICATIONconstant toINITIAL_SETUP_ERROR_NOTIFICATION. The component is shown for any initial setup error (not only Analytics activation), so the new name reflects its actual purpose.Changes:
SetupUsingProxyWithSignIn/index.js.SetupUsingProxyWithSignIn/index-setupFlowRefresh.stories.jsand corresponding test descriptions inSetupUsingProxyWithSignIn/index.test.js.