Skip to content

Map auth proxy setup failures to specific support error_ids#13138

Open
faisalahammad wants to merge 1 commit into
google:developfrom
faisalahammad:fix/13133-auth-proxy-error-ids
Open

Map auth proxy setup failures to specific support error_ids#13138
faisalahammad wants to merge 1 commit into
google:developfrom
faisalahammad:fix/13133-auth-proxy-error-ids

Conversation

@faisalahammad

Copy link
Copy Markdown

Summary

Addresses issue:

Relevant technical choices

Setup "Get help" links for auth-proxy failures previously used the raw WP_Error code, or remapped only request_failed to the parent guide id. Transport failures share generic codes (http_request_failed, http_request_not_executed), so users landed on the wrong or missing support guide.

Setup now resolves error_id from the full WP_Error (message patterns first, then known codes, then the existing request_failed parent remap / pass-through). Doc anchor ids from the issue are used so links target the matching sub-guides. Custom proxy codes from #11752 still pass through unchanged. User-facing error text is unchanged.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Resolve Get help links from the WP_Error code and message so transport
and known proxy failures land on matching documentation sub-guides.
@google-cla

google-cla Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant