Add CTAPreview component shell.#13136
Open
ankitrox wants to merge 4 commits into
Open
Conversation
📚 Storybook for 85afb59: 📦 Build files for 85afb59:
🎭 Playwright reports for 85afb59: |
|
Size Change: +5.54 kB (+0.15%) Total Size: 3.67 MB 📦 View Changed
ℹ️ View Unchanged
|
hussain-t
requested changes
Jul 22, 2026
|
|
||
| export { default as SetupForm } from './SetupForm'; | ||
| export { default as SetupMain } from './SetupMain'; | ||
| export * as SetupMainExpress from './SetupMainExpress'; |
Collaborator
There was a problem hiding this comment.
The develop branch already has it. Please pull the latest and resolve any conflicts.
| const CTA_PREVIEW_TAB_POPUP = 0; | ||
| const CTA_PREVIEW_TAB_INLINE = 1; | ||
|
|
||
| export default function CTAPreview( { |
Collaborator
There was a problem hiding this comment.
Since this is a new component, could we implement it in TypeScript?
| ); | ||
| } | ||
|
|
||
| CTAPreview.propTypes = { |
Collaborator
There was a problem hiding this comment.
Please use the interface with TS.
| @@ -0,0 +1,19 @@ | |||
| /** | |||
| * Reader Revenue Manager SetupMainExpress components. | |||
Collaborator
There was a problem hiding this comment.
develop already has SetupMainExpress/index.tsx. This barrel should be removed; CTAPreview can be imported from its own path (SetupMainExpress/CTAPreview).
| @@ -0,0 +1,39 @@ | |||
| /** | |||
| * Reader Revenue Manager CTAPreview component stories. | |||
Collaborator
There was a problem hiding this comment.
Please migrate it to TypeScript.
| /** | ||
| * Reader Revenue Manager CTAPreview component tests. | ||
| * | ||
| * Site Kit by Google, Copyright 2025 Google LLC |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Site Kit by Google, Copyright 2025 Google LLC | |
| * Site Kit by Google, Copyright 2026 Google LLC |
| /** | ||
| * Reader Revenue Manager CTA Preview styles. | ||
| * | ||
| * Site Kit by Google, Copyright 2025 Google LLC |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Site Kit by Google, Copyright 2025 Google LLC | |
| * Site Kit by Google, Copyright 2026 Google LLC |
Comment on lines
+42
to
+44
| .googlesitekit-rrm-cta-preview__description { | ||
| text-align: left; | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: a few lines here (42-44, 81-83, 91-93) are space-indented while the rest of the file uses tabs. Can we make it consistent?
| } | ||
| } | ||
|
|
||
| .mdc-tab__ripple { |
Collaborator
There was a problem hiding this comment.
Hiding .mdc-tab__ripple also removes the visible keyboard focus state. Could we keep it or add a :focus-visible style?
|
|
||
| .googlesitekit-plugin { | ||
|
|
||
| .googlesitekit-rrm-cta-preview { |
Collaborator
There was a problem hiding this comment.
The IB calls for a rounded card, but the container has no border radius. Could we add the appropriate border radius? As per the Figma design, the container should have an 8px border-radius.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist