Fix URL change detection broken by database search and replace#13135
Open
shervElmi wants to merge 5 commits into
Open
Fix URL change detection broken by database search and replace#13135shervElmi wants to merge 5 commits into
shervElmi wants to merge 5 commits into
Conversation
🎭 Playwright reports for 7e1de03: 📦 Build files for 7e1de03:
|
Store the setting base64-encoded, so a database search and replace leaves it alone and URL change detection keeps working. The getter decodes on read, and a value an earlier version stored in plain text passes through unchanged.
Re-save the connected proxy URL on admin_init, so a value an earlier version stored in plain text becomes encoded. The migration runs once and then stamps the DB version option.
Add the migration to the plugin's registration list, so it runs alongside the earlier migrations.
shervElmi
force-pushed
the
bug/12962-encode-connected-proxy-url
branch
from
July 22, 2026 13:54
ef75334 to
984a68f
Compare
shervElmi
marked this pull request as ready for review
July 22, 2026 13:55
Rephrase comments to enhance understanding of how legacy values are stored and processed. This improves code readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
set(), so a value written straight to the option, as the options screen writes it, still stores encoded.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist